-
-
Notifications
You must be signed in to change notification settings - Fork 4.9k
Cleanup Server.php (aliases & services) #12225
Copy link
Copy link
Open
Labels
1. to developAccepted and waiting to be taken care ofAccepted and waiting to be taken care ofgood first issueSmall tasks with clear documentation about how and in which place you need to fix things in.Small tasks with clear documentation about how and in which place you need to fix things in.technical debt🧱 🤔🚀🧱 🤔🚀
Metadata
Metadata
Assignees
Labels
1. to developAccepted and waiting to be taken care ofAccepted and waiting to be taken care ofgood first issueSmall tasks with clear documentation about how and in which place you need to fix things in.Small tasks with clear documentation about how and in which place you need to fix things in.technical debt🧱 🤔🚀🧱 🤔🚀
Type
Fields
Give feedbackNo fields configured for issues without a type.
As discussed with @MorrisJobke
We regsiter a lot of plain text aliases like
server/lib/private/Server.php
Line 182 in 9319d55
They should all die. Services should be queries properly using their servicename.
Ideally we also remove as much simple wrappers as possible like:
server/lib/private/Server.php
Lines 256 to 258 in 9319d55
The DI can handle that all perfectly by itself when it is actually needed.