fix(settings): use proper component structure to make navigation work#60236
Open
fix(settings): use proper component structure to make navigation work#60236
Conversation
nfebe
approved these changes
May 8, 2026
sorbaugh
approved these changes
May 8, 2026
pringelmann
reviewed
May 8, 2026
pringelmann
approved these changes
May 8, 2026
Contributor
pringelmann
left a comment
There was a problem hiding this comment.
🚀 Just one question about removal of data attrs
Contributor
Author
|
/compile |
Contributor
|
/compile |
susnux
commented
May 8, 2026
`NcAppNavigation` is only allowed in `NcContent` but we were not using it because the content was rendered by the server as templates. This is now fixed by moving the content inside the `NcContent` once mounted. Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NcAppNavigationis only allowed inNcContentbut we were not using it because the content was rendered by the server as templates. This is now fixed by moving the content inside theNcContentonce mounted.Checklist
3. to review, feature component)stable32)AI (if applicable)