Skip to content

feat: allow symfony 7#76

Merged
wazelin merged 2 commits into
oat-sa:masterfrom
kochen:allow_symfony_7
Nov 9, 2025
Merged

feat: allow symfony 7#76
wazelin merged 2 commits into
oat-sa:masterfrom
kochen:allow_symfony_7

Conversation

@kochen
Copy link
Copy Markdown
Contributor

@kochen kochen commented Jan 3, 2025

closes #75

Summary by CodeRabbit

  • Chores
    • Broadened Symfony compatibility to allow Symfony 7.3 in addition to 6.4 across framework and related packages; updated dev tooling compatibility.
  • Documentation
    • Minor doc formatting cleanup and clarifications in platform/tool messaging docs.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Jul 4, 2025

Walkthrough

Expanded Symfony version constraints in composer.json to permit Symfony 7.3 alongside 6.4, and replaced several imports of Symfony\Component\Security\Core\Security with Symfony\Bundle\SecurityBundle\Security across code, tests, and docs. No functional logic changes.

Changes

Cohort / File(s) Change Summary
Composer manifest
composer.json
Expanded Symfony-related version constraints to allow Symfony 7.3 in addition to 6.4 (updated require entries and one require-dev entry).
Security import updates
Service/Server/Factory/LtiServiceServerHttpFoundationRequestHandlerFactory.php, Service/Server/Handler/LtiServiceServerHttpFoundationRequestHandler.php, Tests/Resources/Action/Platform/Message/TestPlatformMessageAction.php, Tests/Resources/Action/Tool/Message/TestToolMessageAction.php, Tests/Resources/Service/Server/Handler/TestServiceRequestHandler.php, doc/message/platform.md, doc/message/tool.md, doc/service/platform.md
Replaced import of Symfony\Component\Security\Core\Security with Symfony\Bundle\SecurityBundle\Security in source, test, and documentation files. No changes to method signatures or runtime logic beyond the import/type resolution.

Sequence Diagram(s)

The changes are limited to dependency version constraints and import paths and do not modify control flow; no sequence diagram is provided.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Potential review focus:

  • Confirm composer.json constraints are syntactically correct and cover all necessary Symfony packages.
  • Ensure replacing Security import with Symfony\Bundle\SecurityBundle\Security is intentional and compatible with dependency injection/configuration across the application and tests.
  • Spot-check the modified files for accidental namespace collisions or missing use statements.
  • Verify documentation updates reflect the intended import change and remain accurate.

Pre-merge checks and finishing touches

✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main objective of the changeset - adding Symfony 7 compatibility by updating version constraints in composer.json and importing the correct Security class.
Linked Issues check ✅ Passed The pull request addresses issue #75 by expanding Symfony package version constraints to allow Symfony 7.3 compatibility and updating Security class imports across multiple files.
Out of Scope Changes check ✅ Passed All changes are directly related to Symfony 7 compatibility: composer.json constraints are updated for Symfony 7.3 support, and Security class imports are updated to use the correct namespace for Symfony 7 compatibility.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Jira integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 9015199 and f160b69.

📒 Files selected for processing (8)
  • Service/Server/Factory/LtiServiceServerHttpFoundationRequestHandlerFactory.php (1 hunks)
  • Service/Server/Handler/LtiServiceServerHttpFoundationRequestHandler.php (1 hunks)
  • Tests/Resources/Action/Platform/Message/TestPlatformMessageAction.php (1 hunks)
  • Tests/Resources/Action/Tool/Message/TestToolMessageAction.php (1 hunks)
  • Tests/Resources/Service/Server/Handler/TestServiceRequestHandler.php (1 hunks)
  • doc/message/platform.md (1 hunks)
  • doc/message/tool.md (1 hunks)
  • doc/service/platform.md (2 hunks)
🔇 Additional comments (8)
Tests/Resources/Action/Tool/Message/TestToolMessageAction.php (1)

27-27: LGTM: Security import updated for Symfony 7 compatibility.

The import change from Symfony\Component\Security\Core\Security to Symfony\Bundle\SecurityBundle\Security is required for Symfony 7, where the old class location was removed.

doc/message/platform.md (1)

252-252: LGTM: Documentation updated with correct Security import.

The documentation example now uses Symfony\Bundle\SecurityBundle\Security, consistent with Symfony 7 compatibility requirements.

doc/service/platform.md (1)

146-146: LGTM: Documentation updated with correct Security import.

The documentation example correctly uses Symfony\Bundle\SecurityBundle\Security for Symfony 7 compatibility.

Service/Server/Factory/LtiServiceServerHttpFoundationRequestHandlerFactory.php (1)

31-31: LGTM: Security import updated for Symfony 7 compatibility.

The import path change is required for Symfony 7 support where Symfony\Component\Security\Core\Security was removed.

doc/message/tool.md (1)

138-138: LGTM: Documentation updated with correct Security import.

The documentation example uses Symfony\Bundle\SecurityBundle\Security, ensuring developers follow Symfony 7-compatible patterns.

Service/Server/Handler/LtiServiceServerHttpFoundationRequestHandler.php (1)

35-35: LGTM: Security import updated for Symfony 7 compatibility.

The import change from Symfony\Component\Security\Core\Security to Symfony\Bundle\SecurityBundle\Security is necessary for Symfony 7 where the old location was removed.

Tests/Resources/Service/Server/Handler/TestServiceRequestHandler.php (1)

32-32: LGTM: Security import updated for Symfony 7 compatibility.

The import path change ensures test resources remain compatible with Symfony 7.

Tests/Resources/Action/Platform/Message/TestPlatformMessageAction.php (1)

27-27: Security import successfully updated for Symfony 7 compatibility.

The verification confirms no remaining usages of the deprecated Symfony\Component\Security\Core\Security import exist in the codebase. The migration to Symfony\Bundle\SecurityBundle\Security is complete.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@kochen kochen force-pushed the allow_symfony_7 branch from 0b79ee4 to 7c1b490 Compare July 27, 2025 14:16
@zluiten
Copy link
Copy Markdown

zluiten commented Nov 7, 2025

@kilatib or @weaverryan, could you have a look at this please? It's currently holding us back to upgrade other dependencies in our project.

@kochen
Copy link
Copy Markdown
Contributor Author

kochen commented Nov 7, 2025

Update the PR to allow Symfony 7.3 (as 7.2 is already EOL)

@wazelin
Copy link
Copy Markdown
Member

wazelin commented Nov 7, 2025

It looks like this is not as simple as just allowing a more recent version of symfony.

I'll try and see what needs to be updated to pass the tests and make sure the functionality is intact.

@wazelin wazelin merged commit 0a7e507 into oat-sa:master Nov 9, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow Symfony 7

3 participants