Add Map Chopping Block#3952
Conversation
|
SAM seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
WalkthroughAdds a new playable map "Chopping Block": map asset and manifest files, a new GameMapType entry, and integration into the map generator, English translations, and playlist rotation. ChangesChopping Block Map Addition
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/core/game/Game.ts`:
- Line 175: Add unit tests that cover the new enum member and its registration:
write a test asserting that the GameCategory (or relevant enum/class) includes
the "ChoppingBlock" member (e.g., check Game.ChoppingBlock or export where the
enum is defined) and another test asserting that the arcade category
registration (the function or map used to register categories, e.g.,
registerCategory or arcadeCategoryEntries) contains the ChoppingBlock entry;
ensure tests import the same symbols added in Game.ts and assert
membership/values so CI enforces the src/core/ change.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 2f20a946-4c81-4416-9370-6526bd2ff21c
⛔ Files ignored due to path filters (4)
map-generator/assets/maps/choppingblock/image.pngis excluded by!**/*.pngresources/maps/choppingblock/map.binis excluded by!**/*.binresources/maps/choppingblock/map16x.binis excluded by!**/*.binresources/maps/choppingblock/map4x.binis excluded by!**/*.bin
📒 Files selected for processing (7)
map-generator/assets/maps/choppingblock/info.jsonmap-generator/main.goresources/lang/en.jsonresources/maps/choppingblock/manifest.jsonresources/maps/choppingblock/thumbnail.webpsrc/core/game/Game.tssrc/server/MapPlaylist.ts
|
@coderabbitai Dismiss change request. New maps added to src dont need to be denoted in a test. No map is denoted in a test by name |
|
Tip For best results, initiate chat on the files or code changes. 🧩 Analysis chain🏁 Script executed: Length of output: 27881 🏁 Script executed: Length of output: 266
Unfortunately, I don't have permission to dismiss the change request programmatically in this repo. You or another maintainer can dismiss it manually via the GitHub PR UI ("Dismiss review" under the review). I've noted this for future reviews: ✏️ Learnings added
|
|
This maps seems a bit crazy.. not sure how the gameplay is on it? |
Thats what I wanted to test. I can only do so much with bot testing. I intended to submit two other arcade style maps that are less 'crazy' overall when it comes to the rates of conquest. This map (given its name) seems to allow for the fast cutting up of your opponents. I found it interesting and played into it as a design element. The map was sectioned in four in effort to slow this down, but I didn't want to make another island map. This is meant to be a fast play/anti-stalemate kind of map in contrast to Los Angeles that I've seen go on for over 40 minutes at times. |
Description:
Describe the PR.
Custom designed map based off of a wooden chopping block pattern/production method.
About 50 additional named nations have been added along with the 32 default.
Map is setup for 2 and 4 teams.
https://www.youtube.com/watch?v=SVwQWMtZRuI
https://discord.com/channels/1284581928254701718/1482787372654399489/1482787372654399489
Please complete the following:
Please put your Discord username so you can be contacted if a bug or regression is found:
PlaysBadly