Display player flags next to their names again

[VariableVince]

Description:

Display flags again.

Please complete the following:

• I have added screenshots for all UI updates
• I process any text displayed to the user through translateText() and I've added it to the en.json file
• I have added relevant tests to the test directory
• I confirm I have thoroughly tested these changes and take full responsibility for any bugs introduced

Please put your Discord username so you can be contacted if a bug or regression is found:

tryout33

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 2681af3f-f0b4-42a8-a1e6-03799d51b196

📥 Commits

Reviewing files that changed from the base of the PR and between ed928db and 77f1fd9.

📒 Files selected for processing (3)

• src/client/WebGLFrameBuilder.ts
• src/core/AssetUrls.ts
• tests/AssetUrls.test.ts

---

Walkthrough

The player synchronization in WebGLFrameBuilder now normalizes cosmetics flag values from newly discovered players. Before sending PlayerStatic data to the WebGL renderer, the code derives a clean flag identifier by either stripping a flag: prefix or extracting the name from a /flags/<name>.svg path pattern.

Changes

Player flag synchronization normalization

Layer / File(s)	Summary
Flag extraction helper and tests src/core/AssetUrls.ts, tests/AssetUrls.test.ts	Adds exported extractFlagName(flagData: string) that parses flag:Name tokens or CDN/path /flags/<name>.<hash>.svg inputs, strips trailing hex hashes, safely decodes the name, and falls back to the original input; tests validate prefix handling, URL/path extraction, decoding, malformed percent-encodings, and edge cases.
WebGLFrameBuilder integration src/client/WebGLFrameBuilder.ts	Imports extractFlagName and uses it when constructing PlayerStatic.flag from p.cosmetics.flag, assigning the cleaned name instead of forwarding the raw input.

Sequence Diagram(s)

sequenceDiagram
  participant Client as Client
  participant WebGLFrameBuilder as src/client/WebGLFrameBuilder
  participant AssetUrls as src/core/AssetUrls.extractFlagName
  participant Renderer as WebGLRenderer
  Client->>WebGLFrameBuilder: new player data (p)
  WebGLFrameBuilder->>AssetUrls: extractFlagName(rawFlag)
  AssetUrls-->>WebGLFrameBuilder: cleanedFlag
  WebGLFrameBuilder->>Renderer: emit PlayerStatic(flag=cleanedFlag)

Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Suggested reviewers

• evanpelle

Poem

🚩 A tiny helper trims the thread,
From flag: tags and CDN spread.
It peels the hash, decodes the name,
So player flags behave the same.
Renderers thank the tidy flame.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title directly and clearly describes the main change: restoring the display of player flags next to their names, which is the primary objective across all modified files.
Description check	✅ Passed	The description is related to the changeset, explaining that flags are being restored and confirming that tests, translations, and screenshots have been added as required.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@src/core/AssetUrls.ts`:
- Around line 111-115: The code currently calls decodeURIComponent directly in
the flag extraction logic (the block that uses
flagData.match(/\/flags\/([^?#]+)\.svg/)), which can throw on malformed
percent-encodings; replace that direct call with the existing
safeDecodeAssetSegment helper (use safeDecodeAssetSegment(raw)) in the same
function (extractFlagName / the flag extraction branch) and ensure any fallback
behavior mirrors other uses in this file (return raw or undefined on decode
failure). Also add unit tests for extractFlagName covering normal inputs,
malformed encodings (e.g., percent sequences that would throw), and edge cases
like names containing colons or URLs with hashes to validate the safe decode
behavior.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 891ee619-fb3b-49ea-afa5-e0bdae567fc7

📥 Commits

Reviewing files that changed from the base of the PR and between 73a6469 and f51b19a.

📒 Files selected for processing (2)

• src/client/WebGLFrameBuilder.ts
• src/core/AssetUrls.ts

🚧 Files skipped from review as they are similar to previous changes (1)

• src/client/WebGLFrameBuilder.ts

[VariableVince]

@CodeRabbit review again please

[coderabbitai]

@VariableVince Sure, triggering a full review of your PR now! 🐇

✅ Actions performed

Full review triggered.