Skip to content

Add MonadGen instance#78

Merged
garyb merged 1 commit into
masterfrom
gen
May 28, 2017
Merged

Add MonadGen instance#78
garyb merged 1 commit into
masterfrom
gen

Conversation

@garyb
Copy link
Copy Markdown
Member

@garyb garyb commented Apr 4, 2017

No description provided.

@paf31
Copy link
Copy Markdown
Contributor

paf31 commented Apr 4, 2017

Will QC continue to provide the same functions (elements, frequency, etc.)? I assume this will be a major version bump anyway.

Actually, we should probably merge #69 and possibly #63 while we're at it.

@garyb
Copy link
Copy Markdown
Member Author

garyb commented Apr 4, 2017

I don't think it needs to be a major version bump - there are no new dependencies (-gen's dependencies are a subset of -quickcheck's, and there are no changes to the interface).

Updating things to re-export from Gen is fine by me, I figured I'd make this change about as unobtrusive as I could, as it's just so quickcheck can be used with things written for MonadGen.

@paf31
Copy link
Copy Markdown
Contributor

paf31 commented Apr 4, 2017

👍 Seems good to me then. No real harm in a major bump actually, since everyone will only just be getting round to updating now anyway.

@paf31
Copy link
Copy Markdown
Contributor

paf31 commented May 28, 2017

Shall we merge this one?

@garyb garyb merged commit 6603ff4 into master May 28, 2017
@garyb garyb deleted the gen branch May 28, 2017 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants