Skip to content

use triple-quoted strings to avoid backslashes#16

Merged
paf31 merged 1 commit into
purescript:masterfrom
davidchambers:triple-quotes
Nov 6, 2014
Merged

use triple-quoted strings to avoid backslashes#16
paf31 merged 1 commit into
purescript:masterfrom
davidchambers:triple-quotes

Conversation

@davidchambers
Copy link
Copy Markdown
Contributor

This is a readability improvement in my opinion.

Comment thread src/Data/String.purs
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about this?

return i >= 0 && i < s.length ? Just(s.charAt(i)) : Nothing;

Seems a tad cleaner to me.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree. Sorry, I literally just merged as your message popped up. If you want to send another PR, I'll merge it.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No worries. Thanks for the quick merge!

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#17

paf31 added a commit that referenced this pull request Nov 6, 2014
use triple-quoted strings to avoid backslashes
@paf31 paf31 merged commit 1152224 into purescript:master Nov 6, 2014
@paf31
Copy link
Copy Markdown
Contributor

paf31 commented Nov 6, 2014

Thanks!

@davidchambers davidchambers deleted the triple-quotes branch November 6, 2014 04:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants