@jorinvo: just a typo; and a glitch?#7
Conversation
|
Thanks! And yes, please share your version of the crawler. Don't be afraid! I am not the code I wrote and I don't get offended about changing it. There is never only one right way to do things. |
|
Hello @jorinvo Here we go. Just be warned: It's not a quick read. Please make sure You have a little time to digest it well. And please know: I am VERY grateful!!! Having this including Your tests helped me A LOT! |
|
Sorry, can't see any errors at the link you posted. Your solution looks very interesting! I can imagine this being helpful for otherwise difficult concurrency problems. |
|
Hi dear @jorinvo - many thx for looking.
And please do not get me wrong: Using my stuff for a tool like Yours is *not* what I intend to suggest!
Not at all! I'd never bother You with any PR for this! Not a thought!
Just felt: You deserve to know how helpful Your work was (and still is) for me:
- Spurred me to add 'seen' to my collection - a very fine usecase for sync.Map - and a pattern re-coded so oftenly.
- Spurred me further to support an attribute in there (I badly forgot in my first try).
- Also: Makes a good case for the flexible bufferer (I found it well hidden in the std sources.)
btw: Your family name suggests You might speak German a little? Just wondering ... :-)
|
Please note:
This is what it looked like - and I still have no clue. So, at least we shall keep an eye on it. |
Hi @jorinvo - great pleasure to do so.
btw: I've refactored Your crawler a little.
In particular Your "implementation that abstracts the coordination using channels"
Just I fear: You may not like it ...
Wanna see anyway?