Allow spaces in bootstrap Cargo rustflags#156096
Open
kupiakos wants to merge 1 commit into
Open
Conversation
This is particularly useful when one's home directory contains a space. Without this change, the assert fails with my home directory, even when using `subst` (on Windows) to give the build dir its own drive letter.
Collaborator
|
rustbot has assigned @Mark-Simulacrum. Use Why was this reviewer chosen?The reviewer was selected based on:
|
| cargo.rustflags.propagate_rustflag_envs(cargo.build_compiler_stage); | ||
| cargo.rustdocflags.propagate_rustflag_envs(cargo.build_compiler_stage); | ||
|
|
||
| cargo.rustdocflags.propagate_cargo_env("RUSTDOCFLAGS"); |
Member
There was a problem hiding this comment.
Do we need to apply this here as well?
Is there a way we can add a test for this (e.g., maybe on one or more CI runners we can build in a directory with a path containing spaces)?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is particularly useful when one's home directory contains a space. Without this change, the assert fails with my home directory when running
x test, even when usingsubst(on Windows) to give the build directory its own drive letter.