Skip to content

docs(semantic-release): implement an automated changelog#415

Merged
myii merged 1 commit into
saltstack-formulas:masterfrom
daks:semantic-release
May 14, 2019
Merged

docs(semantic-release): implement an automated changelog#415
myii merged 1 commit into
saltstack-formulas:masterfrom
daks:semantic-release

Conversation

@daks
Copy link
Copy Markdown
Member

@daks daks commented May 14, 2019

"Yes, Salt can release itself!"

@daks daks requested review from javierbertoli and myii May 14, 2019 13:19
@myii
Copy link
Copy Markdown
Contributor

myii commented May 14, 2019

The big one! I was wondering who was going to be brave enough for this challenge...

@daks
Copy link
Copy Markdown
Member Author

daks commented May 14, 2019

not such a challenge in reality. Easier than postfix/apt formulas that I tried yesterday... because tests are already OK

Comment thread docs/CONTRIBUTING.rst Outdated
Copy link
Copy Markdown
Contributor

@myii myii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, sorry about all of the documentation comments!

Comment thread docs/CONTRIBUTING.rst Outdated
packages.


Documentation
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After our mini-discussion above, you're not going to be pleased to find out that we remove everything after that point, including this Documentation section...

Comment thread docs/README.rst Outdated
salt-formula
============

|img_travis| |docs| |img_sr|
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
|img_travis| |docs| |img_sr|
|img_travis| |img_sr|

Comment thread docs/README.rst Outdated
.. |docs| image:: https://readthedocs.org/projects/docs/badge/?version=latest
:alt: Documentation Status
:scale: 100%
:target: https://salt-formula.readthedocs.io/en/latest/?badge=latest
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And coupled with that suggestion above, removing these four lines to do with |docs|.

Comment thread docs/README.rst
Comment thread docs/README.rst
Comment thread docs/index.rst Outdated
@@ -0,0 +1,20 @@
.. _index:
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file to be removed since it's unused.

@daks daks force-pushed the semantic-release branch from a281bb6 to b73af20 Compare May 14, 2019 17:21
@myii myii merged commit 834d1a6 into saltstack-formulas:master May 14, 2019
@myii
Copy link
Copy Markdown
Contributor

myii commented May 14, 2019

Brillant, thanks @daks -- merged.

@aboe76
Copy link
Copy Markdown
Contributor

aboe76 commented May 14, 2019

@daks thanks for this, nice work !!!!!

@saltstack-formulas-travis
Copy link
Copy Markdown

🎉 This PR is included in version 0.57.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@daks daks deleted the semantic-release branch May 14, 2019 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants