Tests refactoring#75
Merged
Merged
Conversation
Contributor
pmaasz
commented
Aug 28, 2024
- adding tearDown functions to unset member variables in tests
- reducing duplicate code fragments to also shorten test classes
- adding dataprovider functions to shorten test classes
- updating gitignore to ignore files/dirs created by phpstorm
- renaming test functions for readability
smeghead
reviewed
Aug 28, 2024
| } | ||
|
|
||
| public function testDiagram4(): void | ||
| private function provideDiagrams(): array |
Owner
There was a problem hiding this comment.
In PHP 8.0, references seem to fail if the dataProvider method is private.
I would like to see the dataProvider method changed to public.
https://www.reddit.com/r/PHP/comments/xupzk8/phpunit_data_provider_methods_can_have/
Contributor
Author
There was a problem hiding this comment.
yeah I saw that :D thanks :D
Owner
|
@pmaasz I would like to merge it as soon as the PHP8.0 test on GitHub Actions passes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.