[SceneLoader] Add a special error message handler for DeprecationWarning#384
Merged
fredroy merged 2 commits intoApr 3, 2024
Conversation
…ionWarning Otherwise deprecation messages appears as error which is misleading for users.
alxbilger
reviewed
Feb 14, 2024
Contributor
alxbilger
left a comment
There was a problem hiding this comment.
Do we move on with this PR?
Co-authored-by: Alex Bilger <alxbilger@users.noreply.github.com>
Contributor
Author
|
Yes :) |
Contributor
|
It would be nice, any update @damienmarchal ? |
fredroy
approved these changes
Mar 13, 2024
hugtalbot
reviewed
Mar 13, 2024
| if( py::isinstance(e.type(), py::eval("type(DeprecationWarning)")) ) | ||
| { | ||
| msg_deprecated() << ss.str(); | ||
| }else |
Contributor
There was a problem hiding this comment.
Suggested change
| }else | |
| } | |
| else |
hugtalbot
reviewed
Mar 13, 2024
| { | ||
| msg_error() << ss.str(); | ||
| } | ||
|
|
bakpaul
pushed a commit
to bakpaul/SofaPython3
that referenced
this pull request
Jun 21, 2024
…ing (sofa-framework#384) * [SofaPython3/Plugin] Add a special error message handler for DeprecationWarning Otherwise deprecation messages appears as error which is misleading for users. * Update Plugin/src/SofaPython3/SceneLoaderPY3.cpp Co-authored-by: Alex Bilger <alxbilger@users.noreply.github.com> --------- Co-authored-by: Alex Bilger <alxbilger@users.noreply.github.com>
damienmarchal
added a commit
that referenced
this pull request
Sep 13, 2024
…ing (#384) * [SofaPython3/Plugin] Add a special error message handler for DeprecationWarning Otherwise deprecation messages appears as error which is misleading for users. * Update Plugin/src/SofaPython3/SceneLoaderPY3.cpp Co-authored-by: Alex Bilger <alxbilger@users.noreply.github.com> --------- Co-authored-by: Alex Bilger <alxbilger@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently DeprecationWarning exception risen by python code are reported as msg_error()
which is misleading. The PR detect it so it is reported with msg_deprecated()
This is the source of this:
SofaDefrost/STLIB#117