Check for unless darwin before including aarch64 SVE support#2
Check for unless darwin before including aarch64 SVE support#2nogginly wants to merge 2 commits into
unless darwin before including aarch64 SVE support#2Conversation
|
@stakach fyi. This fixes #1 and if merged I'll be able to use I do have a new problem: I am unable to compile the benchmarker. Now, when I build it I get a new error. This instruction usage is found in two methods:
From searching the web, keep in mind I don't know ARM assembly, it sounds like ARM doesn't support I don't run into this in practice because I'm using the shard for Float32 vectors. If you're OK we can merge this so |
|
@stakach, I decided to try commenting out
At the top I added the following fallbacks to scalar:
After all this 🥳 I am now able to compile Two questions:
|
unless darwin before including aarch64 SVE support
|
Sooooooo ... one more thing: I ran Prior to Crystal 1.20 I distinctly remember not using |
Fixes #1 by including SVE support for
aarch64iff platform is Linux.Here's why (as far as I can make out):
The fix wraps all those SVE/SVE2 cases / requires within
{% unless flag?(:darwin %} ... {% end %}to skip entirely unless Linux.