Quoted -D arguments break system property resolution on Linux with Spring AOT

[smurf667]

Problem description

Repository demonstrating issue: https://github.com/smurf667/spring-boot-maven-plugin-aot-sysprop-quotes
Spring Boot version: 3.5.4
Maven version: 3.9.8
JDK: Eclipse Temurin 21
OS affected: Linux
OS unaffected: Windows

Using spring-boot-maven-plugin with Spring AOT (specifically the process-aot goal), system properties configured via <systemPropertyVariables> are quoted in the generated command line as follows:

return String.format("-D%s=\"%s\"", key, value);

This behavior breaks environment variable substitution when running on Linux. Specifically, system properties fail to resolve properly when set via pom.xml. In this case, the value is surrounded with double quotes at runtime, affecting behavior; no quotes are expected.

Hypothesis

Windows' command-line parsing strips the outer quotes, but Linux preserves them, causing Spring's property resolution to fail. When the value hello is configured, the quoted value "hello" is treated literally, rather than hello.

[mhalbritter]

I wonder why we quote those system properties at all. Usually we need to quote stuff when passing values with spaces to a shell, but we pass them to a ProcessBuilder here.

ProcessBuilder pb = new ProcessBuilder();
pb.command().addAll(List.of("java", "-Dtest=value with spaces", "-jar", "app.jar"));

where app.jar contains this main method:

System.out.println("'" + System.getProperty("test") + "'");

Prints

'value with spaces'

[wilkinsona]

I think it might be due to some round-tripping (that I'm not sure is necessary) with RunArguments. An instance is created by joining the arguments into a space-separated String:

spring-boot/build-plugin/spring-boot-maven-plugin/src/main/java/org/springframework/boot/maven/AbstractRunMojo.java

Lines 312 to 324 in e70edce

	protected RunArguments resolveJvmArguments() {
	StringBuilder stringBuilder = new StringBuilder();
	if (this.systemPropertyVariables != null) {
	stringBuilder.append(this.systemPropertyVariables.entrySet()
	.stream()
	.map((e) -> SystemPropertyFormatter.format(e.getKey(), e.getValue()))
	.collect(Collectors.joining(" ")));
	}
	if (this.jvmArguments != null) {
	stringBuilder.append(" ").append(this.jvmArguments);
	}
	return new RunArguments(stringBuilder.toString());
	}

It's then parsed back into separate arguments:

spring-boot/build-plugin/spring-boot-maven-plugin/src/main/java/org/springframework/boot/maven/RunArguments.java

Lines 56 to 67 in e70edce

	private static String[] parseArgs(@Nullable String arguments) {
	if (arguments == null || arguments.trim().isEmpty()) {
	return NO_ARGS;
	}
	try {
	arguments = arguments.replace('\n', ' ').replace('\t', ' ');
	return CommandLineUtils.translateCommandline(arguments);
	}
	catch (Exception ex) {
	throw new IllegalArgumentException("Failed to parse arguments [" + arguments + "]", ex);
	}
	}

AFAICT, translateCommandline respects the " characters to keep space-separated words all part of the same argument when they're surrounded by quotes.

[smurf667]

Thank you for the fix 👍