Use assertThatException
#10485
Merged
Use assertThatException
#10485
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tran Ngoc Nhan <ngocnhan.tran1996@gmail.com>
Signed-off-by: Tran Ngoc Nhan <ngocnhan.tran1996@gmail.com>
artembilan
requested changes
Oct 13, 2025
| "</beans>"; | ||
| // Load context from a String to avoid IDEs reporting the invalid configuration | ||
| String badContext = | ||
| "<?xml version=\"1.0\" encoding=\"UTF-8\"?>" + |
There was a problem hiding this comment.
Well, since we are already here, please, consider to use Java text block instead of concatenations.
| } | ||
| Resource resource = new ByteArrayResource(badContext.getBytes()); | ||
| assertThatExceptionOfType(BeanDefinitionParsingException.class) | ||
| .isThrownBy(() -> new GenericXmlApplicationContext(resource).close()) |
There was a problem hiding this comment.
We don't need close() since we are going to fail.
| } | ||
| Resource resource = new ByteArrayResource(badContext.getBytes()); | ||
| assertThatExceptionOfType(BeanDefinitionParsingException.class) | ||
| .isThrownBy(() -> new GenericXmlApplicationContext(resource).close()) |
| } | ||
| Resource resource = new ByteArrayResource(badContext.getBytes()); | ||
| assertThatExceptionOfType(BeanDefinitionParsingException.class) | ||
| .isThrownBy(() -> new GenericXmlApplicationContext(resource).close()) |
| public void testProcedureNameAndExpressionExclusivity() { | ||
|
|
||
| assertThatExceptionOfType(BeanDefinitionParsingException.class) | ||
| .isThrownBy(() -> this.bootStrap("nameAndExpressionExclusivity")) |
There was a problem hiding this comment.
Now we prefer to not use this. prefix for method calls.
| assertThatIllegalStateException() | ||
| .isThrownBy(() -> { | ||
| gateway.afterPropertiesSet(); | ||
| gateway.handleRequestMessage(message); |
There was a problem hiding this comment.
We fail here just after gateway.afterPropertiesSet();, therefore second call is not reachable, redundant and misleading.
Plus, this second call is not asserted anyhow.
Well, it just has to go.
Signed-off-by: Tran Ngoc Nhan <ngocnhan.tran1996@gmail.com>
Signed-off-by: Tran Ngoc Nhan <ngocnhan.tran1996@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.