Integration test for Standalone Activities delayed-start#1520
Open
eamsden wants to merge 2 commits into
Open
Conversation
5fc1e69 to
18cc276
Compare
maciejdudko
requested changes
May 13, 2026
Comment on lines
+507
to
+508
| if elapsed_after_start < start_delay.total_seconds() - 0.5: | ||
| desc = await activity_handle.describe() |
Contributor
There was a problem hiding this comment.
This can be flaky in CI setting. It's better to check after completion that desc.last_started_time - desc.schedule_time >= start_delay.total_seconds() - 0.5.
Comment on lines
+482
to
+485
| if server_version is not None and server_version <= (1, 31, 0): | ||
| pytest.skip( | ||
| "Temporal server 1.31.0 accepts but does not honor standalone activity start_delay" | ||
| ) |
Contributor
There was a problem hiding this comment.
Remove this and instead set DEV_SERVER_DOWNLOAD_VERSION in tests/__init__.py.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
Added an integration test for the
start_delayparameter to standalone activities.Why?
There's no existing integration test verifying that the
start_delayparameter is actually respected.Checklist
Closes (none)
How was this tested:
Integration test was run against the
v1.7.1-standalone-nexus-operationstag from temporalio/cliAny docs updates needed?
No