Fixes after PR merge

rest_framework_mongoengine/serializers.py

@@ -24,7 +24,6 @@
     is_abstract_model
 )
 
-
 # This object is used for customization of nested field attributes in DocumentSerializer
 Customization = namedtuple("Customization", [
     'fields',
@@ -656,12 +655,12 @@ def build_compound_field(self, field_name, model_field, child_field):
             field_kwargs['child'] = child_field
 
         return field_class, field_kwargs
-    
+
     def serializer_reference_field_factory(self, field_class):
         return type(
             self.serializer_reference_base_field.__name__,
             (self.serializer_reference_base_field,),
-            {'pk_field_class': field_class,}
+            {'pk_field_class': field_class}
         )
 
     def build_reference_field(self, field_name, relation_info, nested_depth):

tests/models.py

@@ -1,7 +1,10 @@
 """ all models shared in tests
 class names should be unique across whole project
 """
-from mongoengine import Document, DynamicDocument, EmbeddedDocument, fields, DynamicEmbeddedDocument
+from mongoengine import (
+    Document, DynamicDocument, DynamicEmbeddedDocument, EmbeddedDocument,
+    fields
+)
 
 
 class DumbDocument(Document):

tests/test_dynamic.py

@@ -10,8 +10,10 @@
     DocumentSerializer, DynamicDocumentSerializer, EmbeddedDocumentSerializer
 )
 
-from .models import DumbDocument, DumbDynamic, DumbEmbedded, EmbeddingDynamic, DumbDynamicEmbedded, \
-    DocumentEmbeddingDynamic
+from .models import (
+    DocumentEmbeddingDynamic, DumbDocument, DumbDynamic, DumbDynamicEmbedded,
+    DumbEmbedded, EmbeddingDynamic
+)
 from .utils import dedent
 
 
@@ -400,4 +402,4 @@ def test_update(self):
         assert serializer_data_json == new_data_json
 
     def doCleanups(self):
-        DocumentEmbeddingDynamic.drop_collection()
+        DocumentEmbeddingDynamic.drop_collection()

tests/test_reference.py

@@ -1,7 +1,7 @@
 from collections import OrderedDict
 
-from django.test import TestCase
 from bson import DBRef
+from django.test import TestCase
 from mongoengine import Document, fields
 from rest_framework.compat import unicode_repr
 from rest_framework.fields import IntegerField
@@ -325,7 +325,7 @@ class Meta:
         expected = dedent("""
             TestSerializer():
                 id = ObjectIdField(read_only=True)
-                ref = CustomReferencing(queryset=ReferencedDoc.objects, required=False)
+                ref = ReferenceField(queryset=ReferencedDoc.objects, required=False)
         """)
         assert unicode_repr(TestSerializer()) == expected
 
@@ -834,17 +834,17 @@ def test_update_data(self):
 
 class TestReferenceCustomPk(TestCase):
     """Operational test
-    
+
     Test if all operations performed correctly
     """
-    
+
     def doCleanups(self):
         CustomPkModel.drop_collection()
         ReferencingWithCustomPk.drop_collection()
 
     def test_parsing(self):
         input_data = {'ref': 'foo'}
-        
+
         serializer = ReferencingWithCustomPkSerializer(data=input_data)
         # No CustomPkModel object with name 'foo'
         assert not serializer.is_valid(), not serializer.errors
@@ -859,7 +859,7 @@ def test_parsing(self):
         assert serializer.validated_data == expected
 
     def test_retrieve(self):
-        referenced = CustomPkModel.objects.create(name='foo') 
+        referenced = CustomPkModel.objects.create(name='foo')
         referencing = ReferencingWithCustomPk.objects.create(ref=referenced)
         serializer = ReferencingWithCustomPkSerializer(referencing)
 
@@ -871,7 +871,7 @@ def test_retrieve(self):
         assert serializer.data == expected
 
     def test_create(self):
-        referenced = CustomPkModel.objects.create(name='foo') 
+        CustomPkModel.objects.create(name='foo')
 
         input_data = {'ref': 'unexisting'}
         serializer = ReferencingWithCustomPkSerializer(data=input_data)
@@ -892,8 +892,8 @@ def test_create(self):
         assert serializer.data == expected
 
     def test_update(self):
-        referenced = CustomPkModel.objects.create(name='foo') 
-        referenced2 = CustomPkModel.objects.create(name='bar') 
+        referenced = CustomPkModel.objects.create(name='foo')
+        CustomPkModel.objects.create(name='bar')
         instance = ReferencingWithCustomPk.objects.create(ref=referenced)
 
         data = {'ref': 'unexisting'}
@@ -917,17 +917,17 @@ def test_update(self):
 
 class TestListReferenceCustomPk(TestCase):
     """Operational test
-    
+
     Test if all operations performed correctly
     """
-    
+
     def doCleanups(self):
         CustomPkModel.drop_collection()
         ListReferencingWithCustomPk.drop_collection()
 
     def test_parsing(self):
         input_data = {'refs': ['foo', 'bar']}
-        
+
         serializer = ListReferencingWithCustomPkSerializer(data=input_data)
         # No CustomPkModel object with name 'foo'
         assert not serializer.is_valid(), not serializer.errors
@@ -951,8 +951,8 @@ def test_parsing(self):
         assert serializer.validated_data == expected
 
     def test_retrieve(self):
-        referenced = CustomPkModel.objects.create(name='foo') 
-        referenced2 = CustomPkModel.objects.create(name='bar') 
+        referenced = CustomPkModel.objects.create(name='foo')
+        referenced2 = CustomPkModel.objects.create(name='bar')
         referencing = ListReferencingWithCustomPk.objects.create(refs=[referenced, referenced2])
         serializer = ListReferencingWithCustomPkSerializer(referencing)
 
@@ -968,13 +968,13 @@ def test_create(self):
         serializer = ListReferencingWithCustomPkSerializer(data=input_data)
         assert not serializer.is_valid(), not serializer.errors
 
-        referenced = CustomPkModel.objects.create(name='foo') 
+        CustomPkModel.objects.create(name='foo')
 
         input_data = {'refs': ['foo', 'bar']}
         serializer = ListReferencingWithCustomPkSerializer(data=input_data)
         assert not serializer.is_valid(), not serializer.errors
 
-        referenced2 = CustomPkModel.objects.create(name='bar') 
+        CustomPkModel.objects.create(name='bar')
 
         input_data = {'refs': ['foo', 'bar']}
         serializer = ListReferencingWithCustomPkSerializer(data=input_data)
@@ -991,8 +991,8 @@ def test_create(self):
         assert serializer.data == expected
 
     def test_update(self):
-        referenced = CustomPkModel.objects.create(name='foo') 
-        CustomPkModel.objects.create(name='bar') 
+        referenced = CustomPkModel.objects.create(name='foo')
+        CustomPkModel.objects.create(name='bar')
         instance = ListReferencingWithCustomPk.objects.create(refs=[referenced])
 
         data = {'refs': ['unexisting']}