Correctly handle -m and -k flags#37
Conversation
|
@pkryger can i bug you for a review 🙏 since i'm not sure this is the best way to do this. note that pytest does not have a |
pkryger
left a comment
There was a problem hiding this comment.
I think this is perfectly fine, and probably should be released as a fix to a non-working options.
What I'd consider would be:
- adding a
:readerto quote args, so they display nicely intransientpopup, - probably reintroduce
=in:argument, again for display purposes (otherwise the value is concatenated to the argument without a separator), - update
python-pytest--quote-string-optionto only quote unquoted arguments and properly handle '=' sign.
Add a special reader helper to read shell arguments that should go after a short-form pytest flag. Fixes #36.
03beb7c to
92af1e9
Compare
|
thanks! i updated my changes based on your suggestion, but i didn't fully understand them, and i couldn't make it work. i ended up with a custom reader function that takes care of both the quoting and the spacing. it looks nice in the dispatcher modal (try (totally forgot about this for a while, until i hit the issue again recently.) |
|
I think this version is even nicer (and simpler!) than what I thought about. |
|
good to hear! thanks again for your review and ideas 🙏 |
Correctly handle -m and -k flags
Add a special reader helper to read shell arguments that should go after
a short-form pytest flag.
Fixes #36.