Skip to content

Make "-v" argument-regexp match complete string#64

Merged
wbolster merged 1 commit into
wbolster:mainfrom
juergenhoetzel:fix-verbose-init-value
Sep 17, 2022
Merged

Make "-v" argument-regexp match complete string#64
wbolster merged 1 commit into
wbolster:mainfrom
juergenhoetzel:fix-verbose-init-value

Conversation

@juergenhoetzel
Copy link
Copy Markdown
Contributor

@juergenhoetzel juergenhoetzel commented Sep 17, 2022

Prevents invalid substring matches for "--verbose --verbose" init value.

Closes #63.

@juergenhoetzel juergenhoetzel mentioned this pull request Sep 17, 2022
Closed
wbolster
wbolster reviewed Sep 17, 2022
View reviewed changes
Comment thread python-pytest.el Outdated
wbolster
wbolster reviewed Sep 17, 2022
View reviewed changes
Copy link
Copy Markdown
Owner

@wbolster wbolster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small nit; lgtm otherwise

@juergenhoetzel
Make "-v" argument-regexp match complete string
effa368 
Prevents invalid substring matches for "--verbose --verbose" init
value.

Closes wbolster#63.
@wbolster wbolster merged commit bec1483 into wbolster:main Sep 17, 2022
@wbolster
Copy link
Copy Markdown
Owner

wbolster commented Sep 17, 2022

thanks!

@sammorley-short
Copy link
Copy Markdown

sammorley-short commented Sep 26, 2022

I've updated my packages (I use doom emacs, so via doom upgrade) and this doesn't seem to have worked for me. Does there need to be a new release for the package to deploy this? Thanks!

@wbolster
Copy link
Copy Markdown
Owner

wbolster commented Sep 27, 2022

@sammorley-short you should be able to check this yourself: is the 1 line change (see diff for thsi pull request) present in your local copy of that file?

@sammorley-short
Copy link
Copy Markdown

sammorley-short commented Oct 15, 2022

I don't. I have ran doom upgrade multiple times, and have also deleted all my packages in .local/straight/ and pulled them all again.

Am I doing something wrong here?

@wbolster
Copy link
Copy Markdown
Owner

wbolster commented Oct 18, 2022

are you using only melpa stable packages perhaps?

if so, this may help: i just tagged a 3.3.0 release (because why not) which should appear on melpa stable soon. see https://github.com/wbolster/emacs-python-pytest/releases/tag/3.3.0

@wbolster wbolster added the bug Something isn't working label Oct 21, 2022
@sammorley-short
Copy link
Copy Markdown

sammorley-short commented Oct 29, 2022

Yep, that's fixed it now. Thanks all! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wbolster wbolster wbolster approved these changes

Assignees

@juergenhoetzel juergenhoetzel

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Double verbosity setting saving broken

3 participants

@juergenhoetzel @wbolster @sammorley-short