Add Windows support

[zyxir]

On Windows there is no "sh -c" available, so run "cmd /c" instead.

[wbolster]

sorry, this escaped my attention. according to this:

https://emacs.stackexchange.com/questions/41891/differences-between-cmdproxy-exe-and-cmd-exe

• cmd takes /c
• cmdproxy is emacs specific, and takes -c

so perhaps a single (if (eq system-type 'windows-nt) "/" "-") instead of "-" would work?

[zyxir]

First, cmdproxy takes both /c and -c. The point is that cmdproxy does some compatibility-related work, so that most functionalities also work on Windows without extra tuning, and is usually recommended over bare cmd.

Second, the main problem is not about "/" or "-". It is the inexistence of a "sh" command on Windows. If it is required to modify as few code as possible, I think we can do (if (eq system-type 'windows-nt) "cmdproxy" "sh").

[wbolster]

I think we can do (if (eq system-type 'windows-nt) "cmdproxy" "sh")

yep, good idea!

[wbolster]

thanks! 🚀

[lld2001]

@zyxir I'm using msys in windows. So this repo works OK just before this commit. After update this commit, I cant specify to test a single file. Have you met this problem.

python -m pytest  'tests/test_util.py'
# Got ERROR:
# ERROR: file or directory not found: 'tests/test_util.py'

It's OK by using "sh" command.

[lld2001]

I finally found the problem. It's because the test file name should not be wraped with '' in Windows.

This command works:

python -m pytest  tests/test_util.py

[zyxir]

@lld2001 Good point. My Emacs was also installed in MSYS2, but I usually launched Emacs on Windows, so it had no access to sh that way. Maybe something should be done to distinguish native Windows and MSYS2?