Skip to content

Implement CS checking based on the WP_CLI_CS ruleset#157

Merged
schlessera merged 3 commits into
wp-cli:masterfrom
BhargavBhandari90:issue-156
Jun 4, 2020
Merged

Implement CS checking based on the WP_CLI_CS ruleset#157
schlessera merged 3 commits into
wp-cli:masterfrom
BhargavBhandari90:issue-156

Conversation

@BhargavBhandari90
Copy link
Copy Markdown

@BhargavBhandari90 BhargavBhandari90 commented May 11, 2019

Add a PHPCS ruleset using the new WP_CLI_CS standard.

Fixes #156

Related wp-cli/wp-cli#5201

@BhargavBhandari90 BhargavBhandari90 requested a review from a team as a code owner May 11, 2019 18:36
@thrijith thrijith changed the title PHPCS: Add new ruleset to the project Implement CS checking based on the WP_CLI_CS ruleset May 12, 2019
@BhargavBhandari90
Copy link
Copy Markdown
Author

BhargavBhandari90 commented May 12, 2019

Added phpcs ignore for some lines because I was not sure about those lines for now. Let me know what to do for those lines.

@schlessera schlessera merged commit e5aa8af into wp-cli:master Jun 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Adopt and enforce new WP_CLI_CS standard

3 participants