GH-782: Implement ability to use sanctioned executable paths

[ascopes]

If you operate in an overly locked-down corporate environment that disallows running shell/batch scripts or native executables outside sanctioned locations on your local file system, you can specify the path here either via this configuration parameter or via a property such that any executables are first moved to a directory within this location. This is designed to be able to be used within a Maven profile if desired.

Addresses GH-782.

---

TODO:

• implementation
• new integration tests
• documentation for user guide
• documentation for parameter in goal reference
• check if we want to name the parameter differently or leave it as it is?
• AbstractGenerateMojo unit tests
• TemporarySpace unit tests
• AbstractTemporaryLocationProvider unit tests
• SanctionedExecutableTransformer unit tests

[ascopes]

Windows failures are caused by https://bugs.openjdk.org/browse/JDK-8315405. Looks like I'm going to have to maybe make a separate fix to deal with this first to reduce directory name length, or have a caveat that long path names are not supported on Windows. One to do separately.

I believe https://bugs.openjdk.org/browse/JDK-8348664 would avoid this eventually should it get implemented.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.80%. Comparing base (07025ed) to head (933c08b).
⚠️ Report is 9 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #783      +/-   ##
==========================================
+ Coverage   91.60%   91.80%   +0.21%     
==========================================
  Files          58       60       +2     
  Lines        1772     1817      +45     
  Branches      118      121       +3     
==========================================
+ Hits         1623     1668      +45     
  Misses        111      111              
  Partials       38       38              

Files with missing lines	Coverage Δ
...enplugin/fs/AbstractTemporaryLocationProvider.java	100.00% <100.00%> (ø)
...ascopes/protobufmavenplugin/fs/TemporarySpace.java	100.00% <100.00%> (ø)
...enplugin/generation/ProtobufBuildOrchestrator.java	89.02% <100.00%> (+0.07%)	⬆️
...protobufmavenplugin/mojo/AbstractGenerateMojo.java	100.00% <100.00%> (ø)
...pes/protobufmavenplugin/protoc/ProtocExecutor.java	87.26% <100.00%> (+0.26%)	⬆️
...mavenplugin/protoc/targets/PluginProtocTarget.java	100.00% <ø> (ø)
...rotoc/targets/SanctionedExecutableTransformer.java	100.00% <100.00%> (ø)

🚀 New features to boost your workflow:

• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[cdprete]

@ascopes any plans to release this or is there still something blocking it?

[ascopes]

A couple of unit tests still need writing, but I probably wont have time to look at this until Saturday as I am working all week.

Edit: apologies if this sent several times. GitHub appears to be playing up.

[cdprete]

No hurry. ;) Il mar 2 set 2025, 10:07 Ash ***@***.***> ha scritto:

…

*ascopes* left a comment (ascopes/protobuf-maven-plugin#783) <#783 (comment)> A couple of unit tests still need writing, but I probably wont have time to look at this until Saturday as I am working all week. — Reply to this email directly, view it on GitHub <#783 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACAZGWHGSNAE6UBBN5YDMED3QVF3HAVCNFSM6AAAAACFGVZCAWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTENBUGI2DONZQG4> . You are receiving this because you commented.Message ID: ***@***.***>

[ascopes]

@cdprete what I will do for now is merge this as the test I need to write is already being covered by an integration test. I'll get 3.9.0 released now and then finish that bit when I have time.

That should unblock you. Expect a release on Maven Central by approx 8:00 GMT today 👍🏻

Thanks for baring with me.

[cdprete]

Thanks to you for fixing this so fast. 😀 Il mer 3 set 2025, 09:16 Ash ***@***.***> ha scritto:

…

*ascopes* left a comment (ascopes/protobuf-maven-plugin#783) <#783 (comment)> @cdprete <https://github.com/cdprete> what I will do for now is merge this as the test I need to write is already being covered by an integration test. I'll get 3.9.0 released now and then finish that bit when I have time. That should unblock you. Expect a release on Maven Central by approx 8:00 GMT today 👍🏻 Thanks for baring with me. — Reply to this email directly, view it on GitHub <#783 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACAZGWEWDX4BIJ5TLDYKVYD3Q2ITHAVCNFSM6AAAAACFGVZCAWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTENBXHE4DKMJUGQ> . You are receiving this because you were mentioned.Message ID: ***@***.***>