Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New design and migration to emotion(css-in-js) #107

Merged
merged 43 commits into from Nov 19, 2017
Merged

New design and migration to emotion(css-in-js) #107

merged 43 commits into from Nov 19, 2017

Conversation

@vinaypuppal
Copy link
Member

vinaypuppal commented Nov 16, 2017

Removed semantic-ui-react as dependency and migrated css to emotion a css-in-js library for Reactjs

  • Landing page is visually same as in #106
  • Space page is updated with new UI
  • And other pages are in WIP

Check below preview url for demo.

vinaypuppal added 25 commits Nov 13, 2017
…nding-page
@vinaypuppal vinaypuppal changed the base branch from master to develop Nov 16, 2017
@coderplex-bot
Copy link
Collaborator

coderplex-bot commented Nov 16, 2017

Deploy preview ready!

Built with commit 1bc13cc

https://deploy-preview-107--coderplex.netlify.com

vinaypuppal added 2 commits Nov 16, 2017
@M-ZubairAhmed
Copy link
Collaborator

M-ZubairAhmed commented Nov 17, 2017

now working on events cards. Probably we should change the heading of this pr?

@vinaypuppal vinaypuppal changed the title WIP: New Landing page WIP: New design and migration to emotion(css-in-js) Nov 17, 2017
@vinaypuppal
Copy link
Member Author

vinaypuppal commented Nov 18, 2017

@saiabhijitht Do you have any other suggestions/changes for landing page?
If not @M-ZubairAhmed lets merge this PR and you can open new PR's for other page updates.

vinaypuppal added 4 commits Nov 18, 2017
@M-ZubairAhmed
Copy link
Collaborator

M-ZubairAhmed commented Nov 18, 2017

sure please go ahead, I have not committed my latest changes.

@duttakapil
Copy link
Member

duttakapil commented Nov 18, 2017

I would suggest we keep the Price section in the same format on the /space page :
image

The pink color could be changed to the blue put forward by @saiabhijitht

Also, did we add the best before the word free under the "Open Source Learning Guides" heading on our landing page?

@M-ZubairAhmed
Copy link
Collaborator

M-ZubairAhmed commented Nov 18, 2017

yes Kapil we shall edit as per your suggestion.

@pbteja1998
Copy link
Member

pbteja1998 commented Nov 18, 2017

JOIN DISCORD button in home page is not working (in this)

@duttakapil
Copy link
Member

duttakapil commented Nov 19, 2017

Seems to be working for me @pbteja1998

@duttakapil
Copy link
Member

duttakapil commented Nov 19, 2017

However, the learning guides are not showing up in the demo site. Even the Laravel guide is showing "Coming soon". And the Events page as well, it's showing loading under past events

@M-ZubairAhmed
Copy link
Collaborator

M-ZubairAhmed commented Nov 19, 2017

we recently migrated away from semantic UI, we are writing everything from scratch. Request everybody to review the items which are completed.

@buoyantair
Copy link
Collaborator

buoyantair commented Nov 19, 2017

@M-ZubairAhmed What made you take a stand away from semantic-ui ?

@pbteja1998
Copy link
Member

pbteja1998 commented Nov 19, 2017

@duttakapil yeah, @vinaypuppal fixed the link in discord button in recent commit. It was not working before.

@vinaypuppal
Copy link
Member Author

vinaypuppal commented Nov 19, 2017

@duttakapil Ref: #107 (comment)
Can you use github review system to pinpoint change when you want to request some changes rather than explaining them in text.

@vinaypuppal vinaypuppal changed the title WIP: New design and migration to emotion(css-in-js) New design and migration to emotion(css-in-js) Nov 19, 2017
@vinaypuppal
Copy link
Member Author

vinaypuppal commented Nov 19, 2017

Merging this PR. For any changes open new issues mentioning develop branch.

@vinaypuppal vinaypuppal merged commit 3607db6 into develop Nov 19, 2017
3 checks passed
3 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details
@vinaypuppal vinaypuppal deleted the emotion branch Nov 19, 2017
@vinaypuppal
Copy link
Member Author

vinaypuppal commented Nov 19, 2017

BTW develop branch site is accessible at https://dev.coderplex.org

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

7 participants
You can’t perform that action at this time.