Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upreformat - move paragraph direction and image size from style attribute to "classic" attribute #39
+8,563
−8,721
Conversation
| @@ -4,23 +4,23 @@ | |||
| "cell_type": "markdown", | |||
| "metadata": {}, | |||
| "source": [ | |||
| "<img src=\"images/logo.jpg\" style=\"display: block; margin-left: auto; margin-right: auto;\" alt=\"לוגו של מיזם לימוד הפייתון. נחש מצויר בצבעי צהוב וכחול, הנע בין האותיות של שם הקורס: לומדים פייתון. הסלוגן המופיע מעל לשם הקורס הוא מיזם חינמי ללימוד תכנות בעברית.\">" | |||
| "<img alt=\"לוגו של מיזם לימוד הפייתון. נחש מצויר בצבעי צהוב וכחול, הנע בין האותיות של שם הקורס: לומדים פייתון. הסלוגן המופיע מעל לשם הקורס הוא מיזם חינמי ללימוד תכנות בעברית.\" src=\"images/logo.jpg\" style=\"display: block; margin-left: auto; margin-right: auto;\"/>" | |||
This comment has been minimized.
This comment has been minimized.
yammesicka
Sep 14, 2020
Member
If it is OK on your side, I'd prefer not to move around attributes in places where it doesn't make a difference :)
This comment has been minimized.
This comment has been minimized.
ophiry
Sep 14, 2020
Author
I used a html parser (BeautifulSoup) to do the reformatting - there's no direct control on all the details of the generated html
| "לפעמים נרצה לצרף דברי הסבר לקוד שכתבנו.<br>\n", | ||
| "כדי להוסיף הסברים לצד הקוד נשתמש בתו סולמית, ומייד אחריה נכתוב את ההסברים שרצינו לצרף.<br>\n", | ||
| "<p dir=\"rtl\" style=\"text-align: right; direction: rtl; float: right; clear: both;\">\n", | ||
| "לפעמים נרצה לצרף דברי הסבר לקוד שכתבנו.<br/>\n", |
This comment has been minimized.
This comment has been minimized.
| "<li><code>\"_)(*&^%\"</code></li>\n", | ||
| "<li><code>\"_)('*&^%\"</code></li>\n", | ||
| " <li><code>\"_)(\"*&^%\"</code></li>\n", | ||
| "<li><code>\"_)(*&^%\"</code></li>\n", |
This comment has been minimized.
This comment has been minimized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
ophiry commentedSep 14, 2020
re: #37