Skip to content

/ id.javascript.info

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modules, introduction #159

Merged
merged 3 commits into from Nov 30, 2020
Merged

Modules, introduction #159

merged 3 commits into from Nov 30, 2020

Conversation

@tiana30
Copy link
Contributor

@tiana30 tiana30 commented Oct 24, 2020

No description provided.

@tiana30
translate Modules, introduction
Loading status checks…
05c61d9
@javascript-translate-bot javascript-translate-bot requested a review from javascript-tutorial/translate-id Oct 24, 2020
@javascript-translate-bot javascript-translate-bot mentioned this pull request Oct 24, 2020
Open
84 of 174 tasks complete
@tiana30
translate Searching: getElement*, querySelector*
Loading status checks…
e881874
@juuni26
juuni26 requested changes Nov 6, 2020
View changes
Copy link
Contributor

@juuni26 juuni26 left a comment

tolong diperbaiki beberapa bahasanya gan. terima kasih telah membantu projek open source ini berkembang 👋
2-ui/1-document/04-searching-elements-dom/1-find-elements/solution.md Outdated Show resolved Hide resolved
2-ui/1-document/04-searching-elements-dom/1-find-elements/solution.md Show resolved Hide resolved
2-ui/1-document/04-searching-elements-dom/1-find-elements/solution.md Outdated Show resolved Hide resolved
2-ui/1-document/04-searching-elements-dom/1-find-elements/task.md Outdated Show resolved Hide resolved
@javascript-translate-bot
Copy link

@javascript-translate-bot javascript-translate-bot commented Nov 6, 2020

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻
@tiana30
fix translate Searching: getElement
Loading status checks…
f6345de
@tiana30
Copy link
Contributor Author

@tiana30 tiana30 commented Nov 13, 2020

/done
@javascript-translate-bot javascript-translate-bot requested a review from javascript-tutorial/translate-id Nov 13, 2020
@juuni26
juuni26 approved these changes Nov 16, 2020
View changes
Copy link
Contributor

@juuni26 juuni26 left a comment

looks good :)
@juuni26 juuni26 merged commit 2b277d9 into javascript-tutorial:master Nov 30, 2020
1 check passed
1 check passed
license/cla Contributor License Agreement is signed.
Details
@javascript-translate-bot
Copy link

@javascript-translate-bot javascript-translate-bot commented Nov 30, 2020

Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉
@tiana30
Copy link
Contributor Author

@tiana30 tiana30 commented Dec 15, 2020

halo saya mau ngasih tahu jadi file yang aku pull request disini kan ada dua yang satu modules: introduction dan yang satu Searching: getElement*, querySelector* jadi untuk file ini belum dicentang. apa harus di pull request lagi dengan judul file yang ini Searching: getElement*, querySelector*
@juuni26
Copy link
Contributor

@juuni26 juuni26 commented Dec 16, 2020

halo saya mau ngasih tahu jadi file yang aku pull request disini kan ada dua yang satu modules: introduction dan yang satu Searching: getElement*, querySelector* jadi untuk file ini belum dicentang. apa harus di pull request lagi dengan judul file yang ini Searching: getElement*, querySelector*

oke done ya
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juuni26 juuni26

Assignees
No one assigned
Labels
needs +1
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@tiana30 @javascript-translate-bot @juuni26
You can’t perform that action at this time.