Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solved issue #522 #623

Closed
wants to merge 7 commits into from
Closed

Solved issue #522 #623

wants to merge 7 commits into from

Conversation

@aliya-rahmani
Copy link
Contributor

@aliya-rahmani aliya-rahmani commented Oct 19, 2020

Simplified language in translation page

@the-knights-who-say-ni
Copy link

@the-knights-who-say-ni the-knights-who-say-ni commented Oct 19, 2020

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@aliya-rahmani

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

Copy link
Collaborator

@willingc willingc left a comment

Hi @aliya-rahmani. Thanks for the documentation change. Please submit the CLA if you haven't already done so. It will automatically update to signed status a day or two after it is submitted.

documenting.rst Outdated Show resolved Hide resolved
documenting.rst Outdated Show resolved Hide resolved
documenting.rst Outdated Show resolved Hide resolved
Co-authored-by: Carol Willing <carolcode@willingconsulting.com>
aliya-rahmani and others added 2 commits Oct 20, 2020
Co-authored-by: Carol Willing <carolcode@willingconsulting.com>
Co-authored-by: Carol Willing <carolcode@willingconsulting.com>
@aliya-rahmani
Copy link
Contributor Author

@aliya-rahmani aliya-rahmani commented Oct 20, 2020

@willingc I've done the recommended changes and signed CLA as well.

@hugovk
Copy link
Contributor

@hugovk hugovk commented Oct 20, 2020

Looks like the 2 commits from #628 have been accidentally included here.

Please could you undo those two from here?

@aliya-rahmani
Copy link
Contributor Author

@aliya-rahmani aliya-rahmani commented Oct 20, 2020

@hugovk I've undone the changes and now the pull request is having 7 commits.

@willingc
Copy link
Collaborator

@willingc willingc commented Oct 21, 2020

Hi @aliya-rahmani, I've merged in your PR #630 and left you a link to a section of the devguide. Would you be able to update this PR to only contain those that relate to documenting.rst?

Remember, for the future, when creating a new change it's important to develop on a new branch instead of master. This will minimize merge conflicts and extraneous files in your new branch when you open a PR. 👍

@aliya-rahmani
Copy link
Contributor Author

@aliya-rahmani aliya-rahmani commented Oct 25, 2020

Hi @willingc, thank's a lot for the guidelines, I'm a beginner so just having some issues with understanding things. I've made a new PR #638 for the issue, plz have a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.