Skip to content

/ Python

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create exchange_sort.py #4600

Merged
merged 4 commits into from Aug 15, 2021
Merged

Create exchange_sort.py #4600

merged 4 commits into from Aug 15, 2021

Conversation

@bonbon99
Copy link
Contributor

@bonbon99 bonbon99 commented Aug 7, 2021 •
edited

Describe your change:

Added exchange sort as referenced from https://en.wikipedia.org/wiki/Sorting_algorithm#Exchange_sort

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.
@bonbon99
Create exchange_sort.py
6c317b9 
added exchange sort
@bonbon99 bonbon99 marked this pull request as ready for review Aug 7, 2021
@bonbon99
Fixed doctest in exchange_sort.py
17f0a98
@L3str4nge
L3str4nge requested changes Aug 9, 2021
View changes
Copy link
Member

@L3str4nge L3str4nge left a comment

Please also take a look at build fail details.
sorts/exchange_sort.py Outdated Show resolved Hide resolved
@bonbon99
Fixed formatting error and added new length variable
37a713a 
added empty line at end of exchange_sort.py and turned len(numbers) into a variable
@L3str4nge
Copy link
Member

@L3str4nge L3str4nge commented Aug 12, 2021

Tests are still failing @bonbon99

@bonbon99
Fixed formatting errors with black
aeb878c 
added empty line
@bonbon99
Copy link
Contributor Author

@bonbon99 bonbon99 commented Aug 14, 2021

Thank you for reviewing @L3str4nge !

@L3str4nge
L3str4nge approved these changes Aug 15, 2021
View changes
@L3str4nge L3str4nge merged commit 032999f into TheAlgorithms:master Aug 15, 2021
2 checks passed
2 checks passed
@github-actions
build
Details
@github-actions
pre-commit
Details
@bonbon99 bonbon99 deleted the bonbon99:exchange_sort branch Aug 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@L3str4nge L3str4nge

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@bonbon99 @L3str4nge