bpo-46841: Use inline caching for `BINARY_OP` #31543

brandtbucher · 2022-02-24T02:18:52Z

Here's a sort-of-rough first pass at implementing this idea. BINARY_OP is easy to start with, since it only uses its cache for the adaptive counter member. Initial perf testing doesn't show any impact, which I think is good (it means that the basic idea works well, even when the cache isn't being used).

Related changes:

All of the dis utilities grow a show_caches parameter, defaulting to False.
wordcode_helpers.h has been moved into compile.c.

https://bugs.python.org/issue46841

Python/ceval.c

Include/internal/pycore_code.h

Python/specialize.c

Python/ceval.c

markshannon · 2022-02-24T11:17:59Z

Doc/library/dis.rst

@@ -24,6 +24,12 @@ interpreter.
      Use 2 bytes for each instruction. Previously the number of bytes varied
      by instruction.

+   .. versionchanged:: 3.11


Maybe don't document this until we are sure it's what we want?

I'd prefer to keep it, and change it if/when dis changes (which is easy enough). That way we don't forget to document it.

OK. Once we've started doing this we will need to complete it before the beta release anyway.

markshannon · 2022-02-24T11:19:12Z

Looks good in general.
I've commented on https://bugs.python.org/issue46841 about what interface we want to add to the dis module.

bedevere-bot · 2022-02-24T21:31:32Z

🤖 New build scheduled with the buildbot fleet by @brandtbucher for commit 1aa079c 🤖

If you want to schedule another build, you need to add the "🔨 test-with-buildbots" label again.

markshannon · 2022-02-25T12:11:09Z

👍
Let the process of inlining the caches commence

brandtbucher added 5 commits Feb 23, 2022

Use inline caching for BINARY_OP instructions

42c9907

Bump the magic number

a446858

Fixup

0393b0d

*facepalm*

8fd41b7

blurb add

4cc3467

brandtbucher requested review from and markshannon as code owners Feb 24, 2022

bedevere-bot added the awaiting core review label Feb 24, 2022

the-knights-who-say-ni added the CLA signed label Feb 24, 2022