Skip to content

Conversation

jpike88
Copy link

@jpike88 jpike88 commented Jun 26, 2018

No description provided.

@jpike88
Copy link
Author

jpike88 commented Jun 26, 2018

@buehler a little help here? is this something you can correct without much drama?

@buehler
Copy link
Owner

buehler commented Jun 26, 2018

The failed tests are because of the changed snapshots.

 "end": undefined,
    +     "name": "{ objParam1, objParam2 }",
    +     "start": undefined,
    +     "type": "any",

but actually, this is "wrong". If you want to handle destructuring, it actually should list the params one by one, not just the object list.

@buehler
Copy link
Owner

buehler commented Jun 26, 2018

Hmm.. it actually should parse destructurings. I'll have a look at it

@jpike88
Copy link
Author

jpike88 commented Jun 26, 2018

Thanks.

I'll cc in @alexkingma as he originally made the fix

@buehler buehler closed this in #72 Jun 27, 2018
buehler added a commit that referenced this pull request Jun 27, 2018
Adding tests for object and array destructuring patterns. Now there are
tests for methods, functions and constructors. Closes #70.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants