-
Notifications
You must be signed in to change notification settings - Fork 44
test: add tests for array and object destructure in class methods #72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #72 +/- ##
===========================================
+ Coverage 89.4% 90.04% +0.63%
===========================================
Files 63 63
Lines 944 944
Branches 167 185 +18
===========================================
+ Hits 844 850 +6
+ Misses 93 87 -6
Partials 7 7
Continue to review full report at Codecov.
|
@buehler any idea when next release is due? would like to ditch my fork |
Wait I'm not understanding why those tests are written like that. If you're parsing destructuring parameters, wouldn't you want to retain that information instead of outputting a flat array?
Should be treated differently from
But those tests seems to treat them the same way. |
actually as I understand the matter, it's parsed into the given variables. So you would rather see the combined variant instead of each of them? examples: function(a, b) {}
// --> [p1: a, p2: b]
function({a, b}){}
// --> [p1: {a, b}] |
Exactly |
Can you do me a favour and modify the tests to look for that output? I'll tweak a PR to suit them if you like |
@buehler thanks you're a legend |
This PR adds tests for array and object destructured parameters in class methods.