Skip to content

Conversation

zanderso
Copy link
Member

@zanderso zanderso commented May 6, 2020

Reverts #55486

Failing on the bots:

devtools stderr: FormatException: Could not find an option named "vm-uri".
devtools stderr: #0      Parser.validate (package:args/src/parser.dart:290:21)
devtools stderr: #1      Parser.parseLongOption (package:args/src/parser.dart:279:7)
devtools stderr: #2      Parser.parse (package:args/src/parser.dart:88:11)
devtools stderr: #3      ArgParser.parse (package:args/src/arg_parser.dart:326:42)
devtools stderr: #4      serveDevToolsWithArgs (package:devtools_server/src/server.dart:89:26)
devtools stderr: <asynchronous suspension>
devtools stderr: #5      main (file:///home/flutter/.pub-cache/hosted/pub.dartlang.org/devtools-0.1.15/bin/devtools.dart:9:3)
devtools stderr: <asynchronous suspension>
devtools stderr: #6      _startIsolate.<anonymous closure> (dart:isolate-patch/isolate_patch.dart:303:32)
devtools stderr: #7      _RawReceivePortImpl._handleMessage (dart:isolate-patch/isolate_patch.dart:172:12)

and later:

Task failed: FileSystemException: Cannot open file, path = '/home/flutter/.cocoon/flutter/dev/benchmarks/complex_layout/devtools_memory.json' (OS Error: No such file or directory, errno = 2)
Stack trace:
dart:io                                                    _File.readAsStringSync
package:flutter_devicelab/tasks/perf_tests.dart 732:42     DevToolsMemoryTest.run.<fn>
===== asynchronous gap ===========================
dart:async                                                 _asyncErrorWrapperHelper
package:flutter_devicelab/framework/framework.dart         _TaskRunner._performTask.<fn>
package:stack_trace                                        Chain.capture
package:flutter_devicelab/framework/framework.dart 169:11  _TaskRunner._performTask
package:flutter_devicelab/framework/framework.dart 101:41  _TaskRunner.run

and:

Task failed: Bad state: Future already completed
Stack trace:
 dart:async                                                 _AsyncCompleter.complete
package:flutter_devicelab/tasks/perf_tests.dart 776:40     DevToolsMemoryTest._launchApp.<fn>
===== asynchronous gap ===========================
dart:async                                                 _BoundSinkStream.listen
package:flutter_devicelab/tasks/perf_tests.dart 769:10     DevToolsMemoryTest._launchApp
===== asynchronous gap ===========================
dart:async                                                 _asyncThenWrapperHelper
package:flutter_devicelab/tasks/perf_tests.dart 708:13     DevToolsMemoryTest.run.<fn>
===== asynchronous gap ===========================
dart:async                                                 _asyncThenWrapperHelper
package:flutter_devicelab/tasks/perf_tests.dart            DevToolsMemoryTest.run.<fn>
package:flutter_devicelab/framework/utils.dart 460:24      inDirectory
package:flutter_devicelab/tasks/perf_tests.dart 703:12     DevToolsMemoryTest.run
package:flutter_devicelab/framework/framework.dart 170:36  _TaskRunner._performTask.<fn>
package:stack_trace                                        Chain.capture
package:flutter_devicelab/framework/framework.dart 169:11  _TaskRunner._performTask
package:flutter_devicelab/framework/framework.dart 101:41  _TaskRunner.run

@fluttergithubbot
Copy link
Contributor

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@fluttergithubbot fluttergithubbot added the c: contributor-productivity Team-specific productivity, code health, technical debt. label May 6, 2020
@zanderso zanderso requested a review from liyuqian May 6, 2020 14:53
@zanderso
Copy link
Member Author

zanderso commented May 6, 2020

TBR

@zanderso zanderso merged commit 19967e2 into master May 6, 2020
@zanderso zanderso deleted the revert-55486-max_memory_test branch May 6, 2020 14:53
@dnfield
Copy link
Contributor

dnfield commented May 6, 2020

LGTM

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants