Skip to content

Revert "Add DevTools memory test" #56445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 6, 2020
Merged

Revert "Add DevTools memory test" #56445

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 0 additions & 18 deletions dev/devicelab/bin/tasks/complex_layout_scroll_perf__devtools_memory.dart
View file
Open in desktop

This file was deleted.

126 changes: 1 addition & 125 deletions dev/devicelab/lib/tasks/perf_tests.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,8 @@
// found in the LICENSE file.

import 'dart:async';
import 'dart:convert' show LineSplitter, json, utf8;
import 'dart:convert' show json;
import 'dart:io';
import 'dart:math' as math;

import 'package:meta/meta.dart';
import 'package:path/path.dart' as path;
Expand Down Expand Up @@ -693,129 +692,6 @@ class MemoryTest {
}
}

class DevToolsMemoryTest {
DevToolsMemoryTest(this.project, this.driverTest);

final String project;
final String driverTest;

Future<TaskResult> run() {
return inDirectory<TaskResult>(project, () async {
_device = await devices.workingDevice;
await _device.unlock();
await flutter('packages', options: <String>['get']);

await _launchApp();
if (_observatoryUri == null) {
return TaskResult.failure('Observatory URI not found.');
}

await _launchDevTools();

await flutter(
'drive',
options: <String>[
'--use-existing-app', _observatoryUri,
'-d', _device.deviceId,
'--profile',
driverTest,
],
);

_devToolsProcess.kill();
await _devToolsProcess.exitCode;

_runProcess.kill();
await _runProcess.exitCode;

final Map<String, dynamic> data = json.decode(
file('$project/$_kJsonFileName').readAsStringSync(),
) as Map<String, dynamic>;
final List<dynamic> samples = data['samples']['data'] as List<dynamic>;
int maxRss = 0;
int maxAdbTotal = 0;
for (final dynamic sample in samples) {
maxRss = math.max(maxRss, sample['rss'] as int);
if (sample['adb_memoryInfo'] != null) {
maxAdbTotal = math.max(maxAdbTotal, sample['adb_memoryInfo']['Total'] as int);
}
}
return TaskResult.success(
<String, dynamic>{'maxRss': maxRss, 'maxAdbTotal': maxAdbTotal},
benchmarkScoreKeys: <String>['maxRss', 'maxAdbTotal'],
);
});
}

Future<void> _launchApp() async {
print('launching $project$driverTest on device...');
final String flutterPath = path.join(flutterDirectory.path, 'bin', 'flutter');
_runProcess = await startProcess(
flutterPath,
<String>[
'run',
'--verbose',
'--profile',
'-d', _device.deviceId,
driverTest,
],
);

// Listen for Observatory URI and forward stdout/stderr
final Completer<String> observatoryUri = Completer<String>();
_runProcess.stdout
.transform<String>(utf8.decoder)
.transform<String>(const LineSplitter())
.listen((String line) {
print('run stdout: $line');
final RegExpMatch match = RegExp(r'An Observatory debugger and profiler on .+ is available at: ((http|//)[a-zA-Z0-9:/=_\-\.\[\]]+)').firstMatch(line);
if (match != null) {
observatoryUri.complete(match[1]);
_observatoryUri = match[1];
}
}, onDone: () { observatoryUri.complete(null); });
_forwardStream(_runProcess.stderr, 'run stderr');

_observatoryUri = await observatoryUri.future;
}

Future<void> _launchDevTools() async {
await exec('pub', <String>[
'global',
'activate',
'devtools',
]);
_devToolsProcess = await startProcess(
'pub',
<String>[
'global',
'run',
'devtools',
'--vm-uri', _observatoryUri,
'--profile-memory', _kJsonFileName,
],
);
_forwardStream(_devToolsProcess.stdout, 'devtools stdout');
_forwardStream(_devToolsProcess.stderr, 'devtools stderr');
}

void _forwardStream(Stream<List<int>> stream, String label) {
stream
.transform<String>(utf8.decoder)
.transform<String>(const LineSplitter())
.listen((String line) {
print('$label: $line');
});
}

Device _device;
String _observatoryUri;
Process _runProcess;
Process _devToolsProcess;

static const String _kJsonFileName = 'devtools_memory.json';
}

enum ReportedDurationTestFlavor {
debug, profile, release
}
Expand Down
6 changes: 0 additions & 6 deletions dev/devicelab/manifest.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -285,12 +285,6 @@ tasks:
stage: devicelab
required_agent_capabilities: ["mac/android"]

complex_layout_scroll_perf__devtools_memory:
description: >
Measures memory usage of the scroll performance test using DevTools.
stage: devicelab
required_agent_capabilities: ["linux/android"]

hello_world_android__compile:
description: >
Measures the APK size of Hello World.
Expand Down