[e2e] fixed code snippet in readme that referenced a non-existent variable

[MaikuB]

Description

The first code snippet for the e2e plugin's readme invokes the exit that uses the value of a result variable that doesn't exist. I'm assuming there's some confusion where result stored the output of calling request_data that isn't used in the context of the code snippet. This PR is to remove that line of code.

Related Issues

Replace this paragraph with a list of issues related to this PR from the issue database. Indicate, which of these issues are resolved or fixed by this PR. Note that you'll have to prefix the issue numbers with flutter/flutter#.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

• I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
• My PR includes unit or integration tests for all changed/updated/fixed behaviors (See [Contributor Guide]).
• All existing and new tests are passing.
• I updated/added relevant documentation (doc comments with ///).
• The analyzer (flutter analyze) does not report any problems on my PR.
• I read and followed the [Flutter Style Guide].
• The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
• I updated pubspec.yaml with an appropriate new version according to the [pub versioning philosophy].
• I updated CHANGELOG.md to add a description of the change.
• I signed the [CLA].
• I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

• Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
• No, this is not a breaking change.

[digiter]

LGTM

[ened]

Sorry @MaikuB our PRs were created at the same time. Could you please rebase?

[MaikuB]

That's done now @ened. I kept the changelog entry under 0.4.3+2 since it hasn't been released yet though. Let me know if I should move it to another entry.

I'm not an expert on Gradle but wondering the plugin version in the PR you had in #2800 should be bumped up higher. As an example, see the 0.3.0 changelog entry for shared_preferences here

[ened]

Hi @MaikuB please adjust the version to the next ‘+‘, as I am not sure when and how the pub gets published and normally tiny changes are kept logged as well.

The Gradle versions are ok, there is the Android gradle plugin at 3.6.3 and the gradle wrapper at 5.6.4 which is the latest that android studio recommends, too.

[MaikuB]

@ened to confirm you mean I should create another changelog entry along with bumping the version next to the + sign? If so, happy to do so

Regarding my point on Gradle versions, what I meant was there are instances where bumps to the plugin and wrapper were marked as a breaking change. Therefore, the version for the Flutter plugin was bumped higher to indicate this. I'm assuming this is because application's that update to a plugin with such changes also need to update their Gradle configuration and that it wouldn't work without doing so (note: I'm not sure if this is actually required as I'm not familiar with the Gradle side of things). Just noticed Android Studio 4.0 is stable now too so may want to consider bumping the AGP to 4.0.0 though I don't know if Flutter has any compatibility issues with it

[ened]

@MaikuB, yes please add the changelog entry & bump the version.

For AGP 4.0, please check if there is an issue open already. If AGP requires a new major Gradle version, I suspect there will be compatibility issues.

For the AGP 3.6.3 bump (which includes the 4.12 -> 5.6 gradle bump), it has been explored thoroughly in other packages in the plugins repo and is safe to do so. I think you have to use the latest AGP & Gradle version in the host application anyway, in order to build a Android app these days. At least Android studio keeps nagging if you did not update and may plainly refuse to function if the built in AS plugin and the AGP version mismatch.

[MaikuB]

@ened sure, it's done now