Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Conversation

ened
Copy link
Contributor

@ened ened commented May 28, 2020

Description

Currently, android build creates the warning message:

Screenshot 2020-05-28 at 13 18 58

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • No, this is not a breaking change.

@ened ened requested a review from digiter as a code owner May 28, 2020 12:24
@ened
Copy link
Contributor Author

ened commented May 28, 2020

@xster you need to share how you made 26a9a22 pass the CI. :)
The commit removes the MainActivity class, which the MainActivityWithPermissionsTest test depends on. It only failed now - but not at the time of your commit.

@ened ened changed the title [e2e] Remove compile warning from Android build [e2e] Android: Remove warning, bump AGP May 28, 2020
Copy link
Contributor

@digiter digiter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@ened ened merged commit a590803 into flutter:master May 28, 2020
EdwinRomelta pushed a commit to EdwinRomelta/plugins that referenced this pull request Jun 11, 2020
Removes Gradle warning & bumps AGP to 3.6.3
jorgefspereira pushed a commit to jorgefspereira/plugins_flutter that referenced this pull request Oct 10, 2020
Removes Gradle warning & bumps AGP to 3.6.3
FlutterSu pushed a commit to FlutterSu/flutter-plugins that referenced this pull request Nov 20, 2020
Removes Gradle warning & bumps AGP to 3.6.3
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants