Skip to content

leveldb properties option bug fix#2

Merged
ls4154 merged 1 commit into
ls4154:masterfrom
min-guk:develop
May 19, 2022
Merged

leveldb properties option bug fix#2
ls4154 merged 1 commit into
ls4154:masterfrom
min-guk:develop

Conversation

@min-guk
Copy link
Copy Markdown
Contributor

@min-guk min-guk commented May 19, 2022

Existing Leveldb properties options had a "Integer underflow" bug on default values.

size_t cache_size = std::stol(props.GetProperty(PROP_CACHE_SIZE, PROP_CACHE_SIZE_DEFAULT))

When we use default option of cache, r-value is long(-1).
But type size_t doesn't support negative value, therefore "Integer underflow" occurs.

Thanks.

@ls4154 ls4154 merged commit 93bfa0a into ls4154:master May 19, 2022
@ls4154
Copy link
Copy Markdown
Owner

ls4154 commented May 19, 2022

Thanks for your PR! :)
I've deleted leveldb.properties from the commit since it is unrelated to this patch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants