Skip to content

leveldb properties option bug fix #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ls4154 merged 1 commit into from
May 19, 2022
Merged

leveldb properties option bug fix #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions leveldb/leveldb.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,3 +8,5 @@ leveldb.max_open_files=1000
leveldb.compression=snappy
leveldb.cache_size=134217728
leveldb.filter_bits=10

# Compression option only supports snappy.
12 changes: 6 additions & 6 deletions leveldb/leveldb_db.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,19 +28,19 @@ namespace {
const std::string PROP_COMPRESSION_DEFAULT = "no";

const std::string PROP_WRITE_BUFFER_SIZE = "leveldb.write_buffer_size";
const std::string PROP_WRITE_BUFFER_SIZE_DEFAULT = "-1";
const std::string PROP_WRITE_BUFFER_SIZE_DEFAULT = "0";

const std::string PROP_MAX_FILE_SIZE = "leveldb.max_file_size";
const std::string PROP_MAX_FILE_SIZE_DEFAULT = "-1";
const std::string PROP_MAX_FILE_SIZE_DEFAULT = "0";

const std::string PROP_MAX_OPEN_FILES = "leveldb.max_open_files";
const std::string PROP_MAX_OPEN_FILES_DEFAULT = "-1";
const std::string PROP_MAX_OPEN_FILES_DEFAULT = "0";

const std::string PROP_CACHE_SIZE = "leveldb.cache_size";
const std::string PROP_CACHE_SIZE_DEFAULT = "-1";
const std::string PROP_CACHE_SIZE_DEFAULT = "0";

const std::string PROP_FILTER_BITS = "leveldb.filter_bits";
const std::string PROP_FILTER_BITS_DEFAULT = "-1";
const std::string PROP_FILTER_BITS_DEFAULT = "0";
} // anonymous

namespace ycsbc {
Expand Down Expand Up @@ -132,7 +132,7 @@ void LeveldbDB::GetOptions(const utils::Properties &props, leveldb::Options *opt
}
size_t cache_size = std::stol(props.GetProperty(PROP_CACHE_SIZE,
PROP_CACHE_SIZE_DEFAULT));
if (cache_size >= 0) {
if (cache_size > 0) {
opt->block_cache = leveldb::NewLRUCache(cache_size);
}
int max_open_files = std::stoi(props.GetProperty(PROP_MAX_OPEN_FILES,
Expand Down